On 4 Jun., 23:20, Cédric Krier <[email protected]> wrote: > Interesting. > > I think as the design is complex a small doc entry about it will be great. > Also as it is not trivial algorithm you should write tests (like for recursion > etc.) > > I see you use executemany instead of the standard way. I suppose it is for > performance but I'm not sure it is a good design choice because you duplicate > a lot of stuffs (like value formating), you lost the abilities of writing > Function fields.
Hi, Function fields and default values are not implemented yet in create_many. But the use of prepared statements was a good performance boost, even if the function field and default value handling is added. > Also I think it will be good to be able to commit particial synchronisation. I will think about a pushing mechanism. I talked with udono at the phone and we worked out some things i will realize before I commit the code to codereview for a real review. Thanks for taking a look at it, Max Holtzberg -- [email protected] mailing list
