On 02/08/11 23:22 +0200, Albert Cervera i Areny wrote:
> Having a look at [1] I realized that there seems to be no coding guideline 
> regarding column and variable names [2]. In this example there's the field 
> 'number_next' which IMHO is both hard to read and remember compared to 
> something more intuitive such as 'next_number'.
> 
> Looking at the source code I see in sale.sale that there's 'total_amount' 
> which is clearly an improvement over OpenERP's 'amount_total' but in the same 
> sale.sale model there's a field named 'invoices_ignored' instead of 
> 'ignored_invoices'.
> 
> Do you think there should be a coding guideline regarding this?

I don't think it is possible to have coding guidelines about this, I prefer to
let this topic to the developers and to the codereview process.
The examples you take come from old code (before codereview) and is a legacy
of OpenERP.
I don't see any issue to fix them as if it is correctly migrated.

-- 
Cédric Krier

B2CK SPRL
Rue de Rotterdam, 4
4000 Liège
Belgium
Tel: +32 472 54 46 59
Email/Jabber: [email protected]
Website: http://www.b2ck.com/

Attachment: pgppj08mt3xiu.pgp
Description: PGP signature

Reply via email to