http://codereview.tryton.org/113002/diff/1/tryton/common/datetime_strftime.py
File tryton/common/datetime_strftime.py (right):

http://codereview.tryton.org/113002/diff/1/tryton/common/datetime_strftime.py#newcode15
tryton/common/datetime_strftime.py:15: year, month, day  =
dt.isoformat().split('-')
Don't understand why you change this code

http://codereview.tryton.org/113002/diff/1/tryton/gui/window/view_form/model/field.py
File tryton/gui/window/view_form/model/field.py (right):

http://codereview.tryton.org/113002/diff/1/tryton/gui/window/view_form/model/field.py#newcode224
tryton/gui/window/view_form/model/field.py:224: return value
get_client must return a str

http://codereview.tryton.org/113002/diff/1/tryton/gui/window/view_form/view/form_gtk/calendar.py
File tryton/gui/window/view_form/view/form_gtk/calendar.py (right):

http://codereview.tryton.org/113002/diff/1/tryton/gui/window/view_form/view/form_gtk/calendar.py#newcode81
tryton/gui/window/view_form/view/form_gtk/calendar.py:81: date =
datetime.date(*time.strptime(value, self.format)[:3])
Why duplicate the code?

http://codereview.tryton.org/113002/diff/1/tryton/gui/window/view_form/view/form_gtk/calendar.py#newcode94
tryton/gui/window/view_form/view/form_gtk/calendar.py:94: value =
datetime_strftime(value, self.format)
Why not keeping the year fix?

http://codereview.tryton.org/113002/

--
[email protected] mailing list

Reply via email to