2011/9/28 Cédric Krier <[email protected]> > On 28/09/11 09:23 -0300, Luis Falcon wrote: > > Hi there ! > > > > Here are some modifications I did to OE's base_vat a while ago. You may > find > > some of the functions useful. > > > > I also included the verification function for Argentina > > A patch is welcome for the issue18 [1]. > There is a lot of tests in vatnumber so adding new validation should also > bring unittests. > We use the same workflow for contribution on vatnumber as in Tryton. > > We'll submit a patch associated to that issue.
> > Add the following functionality > > - The VAT is calculated depending on the country. > > Only known countries are validated. This means only those define in > vatnumber. > > > - No need to insert the two letter code in the VAT number, since it's > > not part of it anyways. Now the function will be calculated from the > > country code taken from the VAT country name > > I don't think we can do that because a Party can have many addresses in > many > countries. So I think it is good to keep the current vat_country field. > > OK > > - Added a verification flag, so you can avoid the verification if you > want. > > If you don't want validation, don't fill the vat_country and just put the > number in vat_number field. > > Good. > > - Change the name of the file "base_vat_data.xml" to "base_vat_view.xml" > > I think this has nothing to do with Tryton :-) > > Indeed it does not . It was forwarded literally .... ;-) > [1] https://code.google.com/p/vatnumber/issues/detail?id=18 > > -- > Cédric Krier > > B2CK SPRL > Rue de Rotterdam, 4 > 4000 Liège > Belgium > Tel: +32 472 54 46 59 > Email/Jabber: [email protected] > Website: http://www.b2ck.com/ > -- Luis Falcón GNU Health health.gnu.org -- [email protected] mailing list
