http://codereview.tryton.org/203002/diff/1/trytond/model/fields/property.py File trytond/model/fields/property.py (right):
http://codereview.tryton.org/203002/diff/1/trytond/model/fields/property.py#newcode99 trytond/model/fields/property.py:99: 'AND "' + property_obj._table + '".res IS NOT NULL ' \ This is wrong. We need to know the default property. http://codereview.tryton.org/203002/diff/1/trytond/model/fields/property.py#newcode118 trytond/model/fields/property.py:118: if clause[2] == False and clause[1] == '=': is False instead of == False Because:
0 == False
True http://codereview.tryton.org/203002/diff/1/trytond/model/fields/property.py#newcode152 trytond/model/fields/property.py:152: elif clause[2] == False: Also test that clause[1] is = or != http://codereview.tryton.org/203002/diff/1/trytond/model/fields/property.py#newcode154 trytond/model/fields/property.py:154: res = "((cast(split_part(value,',',2) as %s) IS NOT NULL) %s %%s) " \ 80 cols http://codereview.tryton.org/203002/diff/1/trytond/model/fields/property.py#newcode157 trytond/model/fields/property.py:157: res = "(cast(split_part(value,',',2) as %s) %s %%s) " % \ Why removing return? http://codereview.tryton.org/203002/ -- [email protected] mailing list
