On 17/11/12 20:48 +0100, Albert Cervera i Areny wrote: > A Diumenge, 4 de març de 2012 03:49:24, [email protected] va escriure: > > Reviewers: , > > > > > > > > Please review this at http://codereview.tryton.org/266002/ > > > > Affected files: > > M trytond/model/modelsql.py > > M trytond/model/modelstorage.py > > M trytond/tests/test_tryton.py > > I recently updated this patch to tip. It'd be great if somebody could review > it. Most of the code does not require in-depth knowledge of trytond core.
We talked at the TUL that we should stabilize the API or at least make
backward compatible changes.
So I'm wondering if we should not do it for this patch.
Some options are possible:
- allow create to work with a list or a dict. I don't like this
solution because we will have the same issue as for
write/delete/browse
- rename create into create_list and add a method create that
convert the dict into a list.
Or we decide that the change worth the non-backward compatible API
change.
--
Cédric Krier
B2CK SPRL
Rue de Rotterdam, 4
4000 Liège
Belgium
Tel: +32 472 54 46 59
Email/Jabber: [email protected]
Website: http://www.b2ck.com/
pgp0cLzcmqMEP.pgp
Description: PGP signature
