On 23/11/12 13:36 +0100, Cédric Krier wrote: > On 23/11/12 12:28 +0000, [email protected] wrote: > > Reviewers: , > > > > > > > > Please review this at http://codereview.tryton.org/599002/ > > Here are the rational for such change. > The current implementation requires to query the fields description in > English to allow to convert the operand into value. This is process is > quite expensive on the translation table. > > I think it doesn't deserve a migration (which will require a lot of > dead code) because normally such record rule should be created in XML > via a module (it is development) and so the XML will fail to load if not > updated. And if someone has write a rule via the client, then there will > be a message during the update because the 'NOT NULL' constraint could > not be set and the Rule will raise an exception when accessed to prevent > unauthorized access.
I would like to push this review but I got no feedback? -- Cédric Krier B2CK SPRL Rue de Rotterdam, 4 4000 Liège Belgium Tel: +32 472 54 46 59 Email/Jabber: [email protected] Website: http://www.b2ck.com/
pgpHTr5CcCzrR.pgp
Description: PGP signature
