-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Al 27/07/13 23:17, En/na Cédric Krier ha escrit: > On 26/07/13 12:52 -0000, Code Review - New issues: ced wrote: >> URL: http://codereview.tryton.org/1001002/ > > I would like to share some changes I have done in this patch with > the refactoring: > > - Field.order_field: > > I remove it and replace by a generic function (similar to default > value) with this form: > > @classmethod def order_<field name>(cls, tables): … > > where tables is a dict of dict containing the joins somthing like > this: > > { None: (invoice, None), 'party': { None: (party, <join_on sql > expression>), 'addresses': { None: (address, <on>), }, }, 'lines': > { None: (invoice_lines, <on>), }, } > > and the method should return a sql expression (or a list) on which > to order. > > this is a more powerful feature then the previous one as it allows > to add tables to join on for the ordering.
This will help to solve isue3306, and therefore issue1085. So for me its worth. Nothing to say about the desing, makes full sense. - -- Sergi Almacellas Abellana www.koolpi.com Twitter: @pokoli_srk -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.11 (GNU/Linux) Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBAgAGBQJR9keFAAoJEGRfwiQCVal5eO8IAI0aew5gRwN6zAUSn5rqvxY2 ZE5EYHsuIhsreIiZRIfETJpSiMrcPpsLqZKpMmj9LGJQLa35hUyGDcATZNzhKySS 2XTIQ+c9senb8V4hpuGVsAPzjBv+r3RFs9+THsXxOqWqPVhynY2Yoh7jOl3ly7eh t7XVplWKF4FevBDomRff+TgZQqXgYA9gxiPCb+HGQ8KR1LVb0skI1SuesJD36vAz qWrRbXvo+G2PX7i2T19iZHIDLvk/7J1DZTbajqZz+n1tz/b0fcUPoQjLT7kIuUOg kFLeb233YhSWrgBcGKsD6xoMBzs8CUHgB/GU6kDyLt4F7+AXzkIQYAqDAHY2FeQ= =KNWW -----END PGP SIGNATURE-----
