El dimarts 17 de setembre de 2013 18:52:58 UTC+2, Cédric Krier va escriure: > > On 17/09/13 18:40 +0200, Jordi Esteve (Zikzakmedia) wrote: > > Al 17/09/13 09:52, En/na Cédric Krier ha escrit: > > >Hi, > > > > > >For me, the new modules bank, account_dunning and > account_dunning_letter > > >are ready for commit. > > >If there is no objection, I will commit them tomorrow. > > For me also they are ready for commit. > > > > It is a pity that the account_payment module > > (http://codereview.tryton.org/926002/) can not be released in next > > v3.0. It has had a lot of revisions and patches, it only misses the > > documentation and maybe a little bug with python-sql library. > > It is missing much more than that. Also it is not a simple module and > his design will have big impact on the future so better to not mess on > the initial release. > > Ok to wait. But, what is it missing in the code review of account_payment module? You say it is missing much more things.
Apart of documentation, test scenarios and maybe a little bug with python-sql library I don't see any missing part. All the blueprint [1] is implemented and the improvements I suggest one month ago [2] haven't had any answers, so maybe they are not too important to be included in the base account_payment module. [1] http://code.google.com/p/tryton/wiki/PaymentOrder [2] https://groups.google.com/forum/#!topic/tryton-dev/laU1GL2hlH8 Jordi
