Hello again,
During this week-end I have coded a small script[1] that could be useful if we were to add it to our codereview instance.This script does some basic checks on the patch that is submitted on codereview (a) it checks that the patch is applicable on the trunk version of the module, (b) it runs the flake8 checker on the repository in order to find the potential infraction to our coding style policy. In order for the module to locate the right module to patch I use the custom we have to prefix the review description by 'module_name:' …
The title regexp is '^([A-Za-z_]\w+)( [0-9.]+)?:' which means that you can specify the version of the module / tryton / trytond the patch is created for. If no version is specified then it considers that the patch is made against trunk. Please in the future use this schema when choosing your review title.
I intent to activate this script sooner or later. So if you have any comment please do not hesitate to make yourself heard!
I activated the bot yesterday. It uses the RSS feed of the open
issues. At first it did not send emails so here are some issues that
the bot has found:
resteve:
http://codereview.tryton.org/1146003/
http://codereview.tryton.org/1147002/
http://codereview.tryton.org/1109003/
http://codereview.tryton.org/1111003/
http://codereview.tryton.org/1117002/
http://codereview.tryton.org/1150002/
http://codereview.tryton.org/1149002/
vvanderleun:
http://codereview.tryton.org/1151002/
sharoon:
http://codereview.tryton.org/847002/
For those involved, please take a look to those patches.
--
Nicolas Évrard
B2CK SPRL
4, rue de Rotterdam
4000 Liège
Belgium
Tel: +32 472 54 46 59
E-mail/Jabber: [email protected]
Website: http://www.b2ck.com/
signature.asc
Description: Digital signature
