On 23/11/13 20:45 +0100, Sergi Almacellas Abellana wrote:
> Hi All,
> 
> As Albert suggested on [1] i think that copy may also be improved in
> the line of [2].
> 
> This is difficult as a the default parameter is not mandatory.
> 
> As copy is a simplification of creating new records I will suggest
> the following improvement:
> 
> def copy(cls, records, default=None, create=True):
> ....
>         to_create = []
>         for data in datas:
>             data = convert_data(field_defs, data)
> to_create.append(data)
>         if not create:
>             return to_create
>         new_records = cls.create(to_create)
> ....

This can not work because of the translations.
Moreover, over time we have removed all the ugly different in and out
type of values because they always generate bugs.

-- 
Cédric Krier - B2CK SPRL
Email/Jabber: [email protected]
Tel: +32 472 54 46 59
Website: http://www.b2ck.com/

Attachment: pgp6gORqLdYt1.pgp
Description: PGP signature

Reply via email to