OK, there is a mistake in the patch. put this : "set_account_ids_remove = set_account_ids - set_account_id2lines" instead of this: "set_account_ids_remove = set_account_id2lines - set_account_ids" can you test ? i will put a patch in codereview
2011/4/17 Bram <[email protected]> > When I remove "account_ids = account_id2lines.keys()" I get the same > output with or without "empty accounts" checked. > Ordering the account in the expected way, but also showing the empty > accounts. > > On 16 apr, 21:01, fares <[email protected]> wrote: > > This confirms that the problem is with the few lines of the code which > > are after "if not datas['form']['empty_account']" in account.py > > and the patch concerns this part of the code > > i think you should check that you applied the patch in a good manner: > > did you remove this line: "account_ids = account_id2lines.keys() " > > also, for your example you should expect this: > > 1300 > > 1801 > > 1802 > > 8400 > > 9200 > > and not this: > > 1801 > > 1802 > > 1300 > > 8400 > > 9200 > > > > Otherwise, this is really strange ! > > > > On 14 avr, 23:23, Farès Hantous <[email protected]> wrote: > > > > > when you check "empty accounts", do you still have the problem? > > > please give a fast feedback > > > > > 2011/4/14 Bram <[email protected]> > > > > > > Applied the patch but I don't notice any difference... > > > > > > Bram > > > > > > -- > > > > [email protected] mailing list > > -- > [email protected] mailing list > -- [email protected] mailing list
