Comment by [email protected]:
I don't see why it should have 2 types of payment. For me, it should be
seen like this: statements are messages received from bank and payments are
messages sent to the bank.
The module should not depend on payment type, this concept is very unclear.
I think payment mode should not be a Model but just a selection field on
the payment which will be filled by modules that will implement bank
communication protocol.
The payment should not be linked to a bank, it is a concept that should
come with the communication protocol.
In Tryton, "order" is never used for naming Models.
In "account.payment.order":
- "name" should be renamed into "number" to follow standard naming of
Tryton. And no need to get a unique constraint (less constraint == more
generic).
- "user" is not needed, if logging is required it could be done with the
history feature.
- "currency", I don't see the usage ? I think in many cases, it will be
allow to sent payment with mixed currencies.
- "done_date" idem as for "user".
In "account.payment.order.line":
- "name", it could be dropped.
- "maturity_date" seems duplicate information with the "move_line"
- "party" idem
- "bank" should be in custom module
- "move_line", why not a Many2One ?
I think it should be possible to change the amount.
Wizard "account.payment.order.add", it should define how the lines will be
selected and how it will prevent to select many time the same line.
For more information:
https://code.google.com/p/tryton/wiki/PaymentOrder
--
--
[email protected] mailing list
