Crap, that's bad of me.. Sorry about that. I updated the commit accordingly and rebased it to the top.
Signed icla via clahub. // Jonatan On Thursday, 5 November 2015 19:02:40 UTC+1, [email protected] wrote: > > On Wed, Nov 4, 2015 at 12:58 PM, Jonatan Olofsson <[email protected] > <javascript:>> wrote: > >> Hi, >> >> A few weeks ago I posted a pull request ( >> https://github.com/gittup/tup/pull/245), but for some reason I forgot to >> email this list.. My bad.. >> >> As you know, there is a feature for Lua configuration to have a default >> description for all directory beneath. The patch I wrote adds a symmetrical >> behaviour for ordinary Tupfiles by adding support for a Tupdefault file, >> which is looked for in exactly the same way - in fact in parallell with - >> Tupdefault.lua-files. >> >> The general algorithm is >> >> 1. Look for Tupfile >> 2. Look for Tupfile.lua >> 3. Look for Tupdefault >> 4. Look for Tupdefault.lua >> 5. Repeat from 3. in parent directory until the configuration root. >> >> >> Note that Tupdefault takes precedence over Tupdefault.lua, just as >> Tupfile takes precedence over Tupfile.lua. >> >> I wasn't 100 % sure on test naming, feel free to correct me. >> >> Comments? Thoughts? >> >> > Hi Jonatan, > > This looks good to me! Though I had to change the while loop to be > while(tent), otherwise I was hitting segfaults (and the new test failed). I > can fix that up before landing though. I can't remember why we didn't add > this symmetry originally when Tupdefault.lua was added, and I haven't been > able to find anything in the mailing list about a reason for not doing so. > > Do you have any objection to filling out a CLA? > http://gittup.org/tup/icla.txt > I'm also looking at using clahub to simplify this. > > -Mike > -- -- tup-users mailing list email: [email protected] unsubscribe: [email protected] options: http://groups.google.com/group/tup-users?hl=en --- You received this message because you are subscribed to the Google Groups "tup-users" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. For more options, visit https://groups.google.com/d/optout.
