dlr         01/06/07 10:34:12

  Modified:    src/java/org/apache/turbine/torque/engine/database/model
                        Database.java
  Log:
  * Merged in a patch from Howard Lin <[EMAIL PROTECTED]> to add the missing
  closing double quote to the end of the database name attribute.
  
  * Additionally, added patch of my own to avoid instantiating
  unnecessary temporary String objects when creating text to append to
  the result.
  
  Revision  Changes    Path
  1.9       +11 -17    
jakarta-turbine/src/java/org/apache/turbine/torque/engine/database/model/Database.java
  
  Index: Database.java
  ===================================================================
  RCS file: 
/home/cvs/jakarta-turbine/src/java/org/apache/turbine/torque/engine/database/model/Database.java,v
  retrieving revision 1.8
  retrieving revision 1.9
  diff -u -r1.8 -r1.9
  --- Database.java     2001/05/31 00:33:11     1.8
  +++ Database.java     2001/06/07 17:34:09     1.9
  @@ -67,7 +67,7 @@
    * @author <a href="mailto:[EMAIL PROTECTED]>Leon Messerschmidt</a>
    * @author <a href="mailto:[EMAIL PROTECTED]>John McNally</a>
    * @author <a href="mailto:[EMAIL PROTECTED]>Martin Poeschl</a>
  - * @version $Id: Database.java,v 1.8 2001/05/31 00:33:11 jmcnally Exp $
  + * @version $Id: Database.java,v 1.9 2001/06/07 17:34:09 dlr Exp $
    */
   public class Database
   {
  @@ -281,26 +281,20 @@
       {
           StringBuffer result = new StringBuffer();
   
  -        result.append ("<database name=\"" + getName());
  -        result.append (" package=\"" + getPackage() + "\"");
  -        result.append (" defaultIdMethod=\"" + getDefaultIdMethod() + "\"");
  -        result.append (" baseClass=\"" + getBaseClass() + "\"");
  -        result.append (" basePeer=\"" + getBasePeer() + "\"");
  -        result.append(">\n");
  +        result.append("<database name=\"").append(getName()).append('"')
  +            .append(" package=\"").append(getPackage()).append('"')
  +            .append(" defaultIdMethod=\"").append(getDefaultIdMethod())
  +            .append('"')
  +            .append(" baseClass=\"").append(getBaseClass()).append('"')
  +            .append(" basePeer=\"").append(getBasePeer()).append('"')
  +            .append(">\n");
   
  -        for (Iterator i = tableList.iterator() ; i.hasNext() ;)
  +        for (Iterator i = tableList.iterator(); i.hasNext(); )
           {
  -            result.append (i.next());
  +            result.append(i.next());
           }
   
  -        result.append ("</database>");
  +        result.append("</database>");
           return result.toString();
     }
   }
  -
  -
  -
  -
  -
  -
  -
  
  
  

---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Reply via email to