Julia Stobbe <[EMAIL PROTECTED]> writes:

> thank you for merging the code.

You're welcome.

> BasePeer.deleteAll(String,String,int) - would work only with default
> connection pool -

Do you have another patch for this one?  ;-)

> another problem regarding transactions will be coming up: when testing
> whether transactions are needed, criteria.containsObjectColumn(dbname)
> only returns true when criteria is not empty...not always a valid
> assumption, i think.

I don't usually need transactions, so forgive me if this is obvious,
but can you provide a use case for this and/or a patch which
illustrates a fix for this insidious situation?

> p.s. why did you "handmerge" the patch? was there something wrong with
> the diff i sent?

There may have been--I forget.  I deal with so much code on a daily
basis that it is very hard to keep track to what I've done to a given
version of any piece of code.

As you probably noticed, I did make some slight changes to your patch.

Daniel

---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Reply via email to