#1 I agree with the policy 99.9%. ;-) In this case we're dealing with a
private inner class, so the only code that used it is already dead. But
that's OK, I made the change.
#2 Oops. Been using diff -cw for so long I forgot.
#3 #$@!#@!#@! Lotus Notes!!!! I wish I could figure out how to fix that.
(See attached file: TurbinePullService.java.patch)
Chris Felaco
Sr. Software Developer
Blue Dolphin Group
(508) 358-6758
Jon Stevens
<jon@latchkey To: turbine-dev
<[EMAIL PROTECTED]>
.com> cc:
Subject: Re: Should the
TurbinePullService use the
06/15/2001 FactoryService to construct global
services?
02:57 PM
Please
respond to
turbine-dev
on 6/15/01 11:21 AM, "[EMAIL PROTECTED]" <[EMAIL PROTECTED]>
wrote:
> Here's the patch. It should be noted that there is a minor repercussion
> here in that a badly configured classname is not discovered until the
> actual instantiation of the global instance. I also removed the Class
> object from the ToolData class, so the session and request components
must
> instantiate the class by name. I don't believe this will pose a
> performance issue.
Close!
#1. Please deprecate the constructor instead of changing it.
<http://jakarta.apache.org/turbine/deprecation.html>
#2. Please submit a patch with diff -u. I can't even read that diff. :-)
#3. Please turn off line wrapping in your email client or submit the patch
as an attachment (or send it to me directly).
Thanks!
-jon
---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
TurbinePullService.java.patch
---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
