On 8/9/01 11:57 AM, "Jon Stevens" <[EMAIL PROTECTED]> wrote:
> -1
>
> I don't like this commit. You aren't even following your own conventions of
> defining the src.XXXX.dir.
>
> Please explain.
Minimizing the number of properties in the build.properties file. The src
directory is the base. In torque and fulcrum I've done the same thing. I'm
not particularly fussy though.
> -jon
>
> on 8/9/01 4:59 AM, "[EMAIL PROTECTED]" <[EMAIL PROTECTED]> wrote:
>
>> jvanzyl 01/08/09 04:59:36
>>
>> Modified: . build.xml
>> Log:
>> - sorry about not checking it in
>>
>> Revision Changes Path
>> 1.3 +3 -8 jakarta-turbine/build.xml
>>
>> Index: build.xml
>> ===================================================================
>> RCS file: /home/cvs/jakarta-turbine/build.xml,v
>> retrieving revision 1.2
>> retrieving revision 1.3
>> diff -u -r1.2 -r1.3
>> --- build.xml 2001/08/09 06:36:28 1.2
>> +++ build.xml 2001/08/09 11:59:36 1.3
>> @@ -15,13 +15,10 @@
>>
>> <property name="build.src" value="${build.dir}/src"/>
>> <property name="build.dest" value="${build.dir}/classes"/>
>> -
>> - <property name="src.adapter.dir" value="${src.dir}/adapter"/>
>> - <property name="src.dtd.dir" value="${src.dir}/dtd"/>
>> <property name="src.java.dir" value="${src.dir}/java"/>
>> <property name="src.test.dir" value="${src.dir}/test"/>
>> - <property name="src.tool.dir" value="${src.dir}/tool"/>
>> -
>> + <property name="src.adapter.dir" value="${src.dir}/adapter"/>
>> + <property name="src.dtd.dir" value="${src.dir}/dtd"/>
>> <property name="final.name" value="${project}-${version}"/>
>> <property name="final.dir" value="../${final.name}/"/>
>>
>> @@ -100,10 +97,8 @@
>> </fileset>
>> </copy>
>>
>> - <!-- We will control this with a property eventually -->
>> <copy todir="${build.src}/org" filtering="yes">
>> - <fileset dir="${src.tool.dir}/org">
>> - </fileset>
>> + <fileset dir="${src.dir}/tool/org"/>
>> </copy>
>>
>> <available
>
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: [EMAIL PROTECTED]
> For additional commands, e-mail: [EMAIL PROTECTED]
--
jvz.
Jason van Zyl
http://tambora.zenplex.org
http://jakarta.apache.org/turbine
http://jakarta.apache.org/velocity
http://jakarta.apache.org/alexandria
http://jakarta.apache.org/commons
---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
