Jason van Zyl wrote:
>On 9/21/01 11:06 AM, "Santiago Gala" <[EMAIL PROTECTED]> wrote:
>
>>Jason van Zyl wrote:
>>
>>>Hi,
>>>
>>>I've added ${variable} interpolation to the ExtendedProperties class so
>>>if you want to take advantage of this feature you'll have to update
>>>your commons-collections jar. This is for turbine 3.x. The variable
>>>interpolation now works in 2.x but the ResourcesService was modified
>>>directly.
>>>
>>Since you changed it (or maybe other changes in turbine-2 HEAD) jetspeed
>>no longer works. It builds, but all services that need this feature
>>receive empty strings. It seems related to a problem with the ordering
>>of service initialization, where the ${webappRoot}/${webapp.dir} vars
>>are not defined when we are trying to use them.
>>
>
>I just built jetspeed but didn't run it. I will try to find the problem
>ASAP. This is definitely a result of a lack of API and the oddness in which
>jetspeed has extended certain parts of Turbine.
>
>I'll look into it and find the problem. I think I know what the problem is.
>
I made it run by doing the following:
- Changing webapp.dir to webappRoot everywhere (it includes TR.p, JR.p
and CastorRegistryService.java). It is funny as, from what I inspect the
code, it should not be needed. But it is :-?
- Wrapping calls to serviceCont,getString() in
conf.getServletContext().getRealPath(). This is due to the fact that
${webappRoot} or ${webapp.dir} do not get expanded. I'm checking why it
happens in other cases. I think it is a race condition with service
initialization, but I'm not yet sure.
< directory = serviceConf.getString("directory");
< mapFile = serviceConf.getString("mapping",DEFAULT_MAPPING);
---
> directory = conf.getServletContext().getRealPath(
serviceConf.getString("directory") );
> mapFile = conf.getServletContext().getRealPath(
serviceConf.getString("mapping",DEFAULT_MAPPING) );
It looks like, in other uses of ${webappRoot}, it gets correctly
expanded. It looks again like the ResourceService returned by doing
ResourceService serviceConf =
((TurbineServices)TurbineServices.getInstance())
.getResources(RegistryService.SERVICE_NAME);
(RegistryService.SERVICE_NAME equals "Registry")
in the init( ServletConfig ) method of CastorRegistryService is not
properly initialized. We are inheriting the TurbineResourceService by a
VariableResourceService, and this can introduce problems during
initialization. I'm trying to find the problems and get rid of the
Jetspeed specific service, now that we have a turbine equivalent.
>
>
>>Are you aware of such problem?
>>
>
>I wasn't aware of the problem, but I am making many changes to the TDK so
>that I can build all turbine applications to check for compatibility
>problems during runtime. Gump will catch problems in the build but what is
>happening with jetspeed is what I dread. People digging into the code
>anywhere and everywhere to get something to work.
>
If something can be done (the language allows it) and it is not clearly
documented, then you can not complain if people does it. I would say
that anything that is not forbidden is permitted.
>
>The variable interpolation is something that could have easily been added to
>the Turbine codebase but was instead added directly to jetspeed. I am using
>the code from jetspeed in the ResourceService in the turbine 2 repository so
>I should be able find it fairly soon.
>
>I would like to slowly try to align jetspeed with the code in Turbine
>because I'm not seeing much activity at all in jetspeed so the project would
>benefit from any and all removal/collapsing of code where there is an
>alternative in the turbine code base.
>
I'm wishing definitely to help here. I'm trying to reduce the Jetspeed
code base to be able to maintain it effectively. Getting rid of
duplications with turbine, as turbine evolves, is a must.
Don't forget that a lot of these alternatives are there because we
started using them, and then a patch was sent to turbine. Quite a few
times, patches sent to turbine for behaviour we needed were ignored or
delayed. As an example, I still have code in Jetspeed to check and
escape commas in ExtendedProperties values, and the patch was sent to
turbine and never applied. If and when it is applied, how do I know my
duplicated method is no longer needed in the Jetspeed codebase?
>
>I will soon be able to build and run jetspeed with the TDK and will be able
>to find problems like this. I still find the jetspeed layout entirely
>confusing and have only been able to get it to run on a few occasions. I
>would like to eliminate this problem.
>
Let us communicate, then. Feel free to ask any question about Jetspeed
internals (I don't know everything, Raphael and David know more about
internals than myself, but I'm good at debugging). Currently I'm working
on security and cleaning template implementation to add a new SAX
template engine.
>
>>Jetspeed works with current snapshot
>>(nightly Sep 12). The change breaking us has taken place between Sep 13
>>and today.
>>
>>I'm not able to understand what's going on.
>>
>>>
>>>The upshot is that you can specify things like:
>>>
>>>myResouce = ${webappRoot}/resources/myResouce.xml
>>>
>>>
>>
>>
>>
>>---------------------------------------------------------------------
>>To unsubscribe, e-mail: [EMAIL PROTECTED]
>>For additional commands, e-mail: [EMAIL PROTECTED]
>>
>
---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
