Peter Donald <[EMAIL PROTECTED]> writes:
> This just makes sure the correct directory is zipped if you specify
> torque.dir in build.properties.
>
> Index: build.xml
> ===================================================================
> RCS file: /home/cvspublic/jakarta-turbine-torque/build.xml,v
> retrieving revision 1.19
> diff -u -r1.19 build.xml
> --- build.xml 2001/10/15 05:54:57 1.19
> +++ build.xml 2001/10/18 01:36:39
> @@ -417,7 +430,7 @@
> </copy>
>
> <zip zipfile="${build.dir}/${final.name}.zip"
> - basedir="${build.dir}/torque"
> + basedir="${torque.dir}"
> />
>
> </target>
Hi Pete. This doesn't seem to be quite right. When one creates a ZIP
file (or any archive), it's generally desirable that the archive
uncompresses into sub-directory whose name corresponds to the name of
the archive (i.e. torque-1.0.zip should uncompress into a subdirectory
named torque or torque-1.0). Since the value of torque.dir defaults
to ${build.dir}/torque/torque, with the patch above we lose that
top-level directory--meaning, when the archive is uncompressed it
explodes all its contents into the cwd (rather than into a new
sub-directory of the cwd).
Line 395:
<property name="torque.dir" value="${build.dir}/torque/torque"/>
A similar change which might be useful would be to supply another
property which maps to ${build.dir}/torque, or refactor the existing
usage to set torque.dir to ${build.dir}/torque.
Daniel
---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
