On 11/1/01 12:37 PM, "Daniel Rall" <[EMAIL PROTECTED]> wrote:
> Dan Bachelder <[EMAIL PROTECTED]> writes: > >> There have been some changes to this task since I wrote that >> patch.. I wouldn't mind creating a new one.. I would also like to >> change the System.out logging I did over to something better... what >> is the desired way to do logging in Torque tasks going forward? >> log()? I think I read in the ant 1.4 release notes that using System >> for logging of any kind can now cause "bad things" to happen. I >> would also like to add the ability to use regex in the >> include/exclude stuff.. if that is desireable which regex package >> should I use? anyone care? > > I dunno if I already replied to this, but once Jason finishes merging > it would be great to get another copy of your patch, Dan. > > Jason, any thoughts on the logging question? I believe that Ant > logging is available from Task subclasses--that strikes me as the > right way to go. I agree, get rid of all the System.println calls with the log() available in the tasks. > I'm -1 on adding another library for only regex matching in one task. > The globbing patterns provided by Ant are generally enough. We don't need regex methods. As the standard build-torque.xml gets cleaned up for general use I think it will cover all cases well. This included the multiple database scenerio. I started using the <fileset> options in the build-torque.xml so that it doesn't matter if you have 1 or 10 datamodel descriptors the actions taken will be the same. > -- > To unsubscribe, e-mail: <mailto:[EMAIL PROTECTED]> > For additional commands, e-mail: <mailto:[EMAIL PROTECTED]> -- jvz. Jason van Zyl http://tambora.zenplex.org http://jakarta.apache.org/turbine http://jakarta.apache.org/velocity http://jakarta.apache.org/alexandria http://jakarta.apache.org/commons -- To unsubscribe, e-mail: <mailto:[EMAIL PROTECTED]> For additional commands, e-mail: <mailto:[EMAIL PROTECTED]>
