"Gonzalo A. Diethelm" <[EMAIL PROTECTED]> writes:

>> -----Original Message-----
>> From: [EMAIL PROTECTED] [mailto:[EMAIL PROTECTED]]
>> Sent: Tuesday, October 30, 2001 16:57 PM
>> To: [EMAIL PROTECTED]
>> Subject: cvs commit: jakarta-turbine-3/src/tool/org/apache/turbine/tool
>> LocalizationTool.java
>> 
>> 
>> dlr         01/10/30 11:57:28
>> 
>>   Modified:    src/tool/org/apache/turbine/tool LocalizationTool.java
>>   Log:
>>   o Renamed getBundleName(Object) to divineBundleName(Object) to make it
>>   less Bean-like (it's not your garden variety accessor method).
>
> Wouldn't guessBundleName(Object) be a more obvious name? Besides having
> this sense, the word "divine" could mean "godly"... More important, it
> may not be obvious what a method called divineXXX() does.

I'd be fine w/ changing the name to use a better verb, but "guess"
isn't really appropriate because a guess isn't being made in the only
two implementations of this method I have (in LocalizationTool and my
subclass in Helm).  Instead, a known algorithm is used.  Also
considered were "extract" and "retrieve".  Have any other suggestions?


--
To unsubscribe, e-mail:   <mailto:[EMAIL PROTECTED]>
For additional commands, e-mail: <mailto:[EMAIL PROTECTED]>

Reply via email to