Patrick Tonidandel wrote: > > Dear John, > > in attachment you will find the diffs for each modified file. >
please provide unified diffs (cvs diff -u) The Value contains lots of commented out code, is there a reason to leave this in? And several lines which you have appeared to just alter the whitespace, why? You have modified a lot of comments in Column.java for no reason, they were under the 80 column limit. Please separate unrelated documentation changes from code changes and I do not see a reason for the doc changes. You deleted an author, what reason do you have for that? Not sure but it appears you may have added tabs? The rule is 4 spaces indentation. I did not look at TypeMap yet, but please clean these up. If you would like to wait until I get some confirmation from jon regarding changes to village, i will let you know personally. john mcnally -- To unsubscribe, e-mail: <mailto:[EMAIL PROTECTED]> For additional commands, e-mail: <mailto:[EMAIL PROTECTED]>
