On 12/20/01 12:30 PM, "Russ Trotter" <[EMAIL PROTECTED]> wrote:
> Ahh... very good! I'd obviously rather not make any code changes. > Thanks for the enlightenment. Should I resubmit a patch sans the code > mod? (it'll probably end up only being a tweak in the table gen velocity > file for mysql) That would be cool. If you can add some tests for the new table types that would be appreciated too. I realize that you have probably tested this yourself but if it can be reproduced in the form of a test that others can use as well than this would be best. > > > Jason van Zyl wrote: > >> On 12/19/01 5:56 PM, "Russ Trotter" <[EMAIL PROTECTED]> wrote: >> >>> Hello, >>> >>> I sent a patch a week or so ago that allowed setting a tableType >>> parameter on the SQL generation phase. I'm not sure what the protocol >>> dictates next. Is there review of this patch by the core committers? >>> Any help would be most appreciated. >>> >> >> I just took a peek at it, you don't need to change the task code, the values >> you put in the build.properties file are available in the context. So just >> by placing tableType in the build.properties will make the value present in >> context. >> >> Second, your patch will be absorbed much more quickly if you provide tests >> along with your additions to make sure that what you change doesn't affect >> anything else. The changes look simple enough but we still run the testbed >> which takes time to get around too. >> >> >>> thanks, >>> russ >>> >>> >>> -- >>> To unsubscribe, e-mail: >>> <mailto:[EMAIL PROTECTED]> >>> For additional commands, e-mail: >>> <mailto:[EMAIL PROTECTED]> >>> >> > > > > -- > To unsubscribe, e-mail: <mailto:[EMAIL PROTECTED]> > For additional commands, e-mail: <mailto:[EMAIL PROTECTED]> -- jvz. Jason van Zyl http://tambora.zenplex.org http://jakarta.apache.org/turbine http://jakarta.apache.org/velocity http://jakarta.apache.org/alexandria http://jakarta.apache.org/commons -- To unsubscribe, e-mail: <mailto:[EMAIL PROTECTED]> For additional commands, e-mail: <mailto:[EMAIL PROTECTED]>
