cvs commit: jakarta-turbine-2/src/java/org/apache/turbine/services/security/db DBSecurityService.java

[jmcnally]

jmcnally    01/12/26 13:24:58

  Modified:    src/java/org/apache/turbine/services/security/db
                        DBSecurityService.java
  Log:
  Why would you ALWAYS throw  an UnknownEntityException?  Is there a good
  reason for this, IMOHO it is not correct.  The same thing was being done for
  savePermission() and saveRole().  This will cause errors any time someone
  tries to update a Group.
  
  patch by Scott Weaver
  
  Revision  Changes    Path
  1.4       +4 -1      
jakarta-turbine-2/src/java/org/apache/turbine/services/security/db/DBSecurityService.java
  
  Index: DBSecurityService.java
  ===================================================================
  RCS file: 
/home/cvs/jakarta-turbine-2/src/java/org/apache/turbine/services/security/db/DBSecurityService.java,v
  retrieving revision 1.3
  retrieving revision 1.4
  diff -u -r1.3 -r1.4
  --- DBSecurityService.java    2001/12/14 17:18:52     1.3
  +++ DBSecurityService.java    2001/12/26 21:24:58     1.4
  @@ -97,7 +97,7 @@
    *
    * @author <a href="mailto:[EMAIL PROTECTED]";>Rafal Krzewski</a>
    * @author <a href="mailto:[EMAIL PROTECTED]";>Marco Kn&uuml;ttel</a>
  - * @version $Id: DBSecurityService.java,v 1.3 2001/12/14 17:18:52 henning Exp $
  + * @version $Id: DBSecurityService.java,v 1.4 2001/12/26 21:24:58 jmcnally Exp $
    */
   public class DBSecurityService extends BaseSecurityService
   {
  @@ -621,6 +621,7 @@
               {
                   Criteria criteria = GroupPeer.buildCriteria(group);
                   GroupPeer.doUpdate(criteria);
  +                return;
               }
           }
           catch(Exception e)
  @@ -648,6 +649,7 @@
               {
                   Criteria criteria = RolePeer.buildCriteria(role);
                   RolePeer.doUpdate(criteria);
  +                return;
               }
           }
           catch(Exception e)
  @@ -675,6 +677,7 @@
               {
                   Criteria criteria = PermissionPeer.buildCriteria(permission);
                   PermissionPeer.doUpdate(criteria);
  +                return;
               }
           }
           catch(Exception e)
  
  
  

--
To unsubscribe, e-mail:   <mailto:[EMAIL PROTECTED]>
For additional commands, e-mail: <mailto:[EMAIL PROTECTED]>