Eric Dobbs <[EMAIL PROTECTED]> writes:

> On Wednesday, February 20, 2002, at 11:06  AM, Eric Dobbs wrote:
>
>> BasePeer calls string.indexOf('.') in various places to parse column
>> names of the TABLE.COLUMN form.  But the User object builds Criteria
>> objects with COLUMN.  This causes StringIndexOutOfBoundsExceptions
>> when performing various operations on Users.  This patch adds checks
>> for the assumption that the column names are TABLE.COLUMN and throws
>> exceptions if that is not the case.
>
> I forgot to add that the exceptions I've thrown have more meaningful
> error messages than StringIndexOutOfBoundsException.

Eric, +1 on committing your patches if you haven't already.  A private
method encapsulating all that error text is my only suggestion.


--
To unsubscribe, e-mail:   <mailto:[EMAIL PROTECTED]>
For additional commands, e-mail: <mailto:[EMAIL PROTECTED]>

Reply via email to