SimpleDateFormat objects are not thread safe. I realize that this class is probably not used in a multi-threaded environment, but mind if I switch it over to using locals for the DateFormat impls?
Dan [EMAIL PROTECTED] writes: > jvanzyl 02/02/24 10:32:01 > > Modified: . build-bootstrap.xml > src/java/org/apache/maven ChangeLog.java > Log: > - update the genjar task, the Target class is no longer required. > > Revision Changes Path > 1.10 +0 -1 jakarta-turbine-maven/build-bootstrap.xml > > Index: build-bootstrap.xml > =================================================================== > RCS file: /home/cvs/jakarta-turbine-maven/build-bootstrap.xml,v > retrieving revision 1.9 > retrieving revision 1.10 > diff -u -r1.9 -r1.10 > --- build-bootstrap.xml 23 Feb 2002 20:41:21 -0000 1.9 > +++ build-bootstrap.xml 24 Feb 2002 18:32:01 -0000 1.10 > @@ -84,7 +84,6 @@ > <class name="org.apache.maven.project.Profile"/> > <class name="org.apache.maven.project.Project"/> > <class name="org.apache.maven.project.Repository"/> > - <class name="org.apache.maven.project.Target"/> > <class name="org.apache.maven.project.Workspace"/> > > <classfilter> > > > > 1.2 +15 -6 jakarta-turbine-maven/src/java/org/apache/maven/ChangeLog.java > > Index: ChangeLog.java > =================================================================== > RCS file: >/home/cvs/jakarta-turbine-maven/src/java/org/apache/maven/ChangeLog.java,v > retrieving revision 1.1 > retrieving revision 1.2 > diff -u -r1.1 -r1.2 > --- ChangeLog.java 24 Feb 2002 05:23:47 -0000 1.1 > +++ ChangeLog.java 24 Feb 2002 18:32:01 -0000 1.2 > @@ -65,7 +65,7 @@ > * > * @author <a href="mailto:[EMAIL PROTECTED]";>Jeff Martin</a> > * @author <a href="mailto:[EMAIL PROTECTED]";>Jason van Zyl</a> > - * @version $Id: ChangeLog.java,v 1.1 2002/02/24 05:23:47 jvanzyl Exp $ > + * @version $Id: ChangeLog.java,v 1.2 2002/02/24 18:32:01 jvanzyl Exp $ > */ > public class ChangeLog > extends Task > @@ -117,20 +117,26 @@ > /** > * input format for dates read in from cvs log > */ > - private final static SimpleDateFormat inputDate = new >SimpleDateFormat("yyyy/MM/dd"); > + private final static SimpleDateFormat inputDate = > + new SimpleDateFormat("yyyy/MM/dd"); > + > /** > * output format for dates writtn to xml file > */ > - private final static SimpleDateFormat outputDate = new >SimpleDateFormat("yyyy-MM-dd"); > + private final static SimpleDateFormat outputDate = > + new SimpleDateFormat("yyyy-MM-dd"); > + > /** > * output format for times writtn to xml file > */ > - private final static SimpleDateFormat outputTime = new >SimpleDateFormat("hh:mm"); > + private final static SimpleDateFormat outputTime = > + new SimpleDateFormat("hh:mm"); > > /** > * Set the input stream for the cvs process. cvs requires no input so this > * is not used. > */ > + > public void setProcessInputStream(OutputStream os) > throws IOException > { > @@ -192,11 +198,13 @@ > } > if (!users.exists()) > { > - throw new BuildException("Cannot find user lookup file " + >users.getAbsolutePath()); > + throw new BuildException( > + "Cannot find user lookup file " + users.getAbsolutePath()); > } > if (!base.exists()) > { > - throw new BuildException("Cannot find base dir " + >base.getAbsolutePath()); > + throw new BuildException( > + "Cannot find base dir " + base.getAbsolutePath()); > } > > if (users != null) > @@ -261,6 +269,7 @@ > String comment = null; > String revision = null; > String previousRev = null; > + > while ((line = in.readLine()) != null) > { > switch (status) > > > > > -- > To unsubscribe, e-mail: <mailto:[EMAIL PROTECTED]> > For additional commands, e-mail: <mailto:[EMAIL PROTECTED]> -- To unsubscribe, e-mail: <mailto:[EMAIL PROTECTED]> For additional commands, e-mail: <mailto:[EMAIL PROTECTED]>
