> -----Original Message-----
> From: Stephane Bailliez [mailto:[EMAIL PROTECTED]]
> I realize it was not ideal but could not find a suitable name. I
> changed it
> to KeywordsFormat (there is still the format of each keyword in
> it which may
> or may not be used later). I changed the 'format' method to
> 'update' so that
> it match more or less the reset.
KeywordsFormat is much better.
Note that the particular ASCII format that RCS and CVS use for archives is quite
independent of the internal logic of the archive. One could reasonably save the
archive using another format, and one could support the formats of other version
control tool using Archive.
That means that the code that converts the Archive to a string could be factored out
into an ArchiveFormat (or RCSArchiveFormat) class (using the Visitor pattern f.e.)
> A couple of things I would like to do to so that it helps me
> finding what do
> what.
> - continue changing the _ coding style.
> - remove the fully qualified classnames in the code.
> - use getters instead of direct access to protected attributes for classes
> in the same package.
>
> Sound reasonable ?
+1
Juanco
