It's not threadsafe. the calendar attribute of DateFormat is set to the date value to format.
Considering the simple formatting (no locale) you can do a better job with a field concatenation no ? Stephane ----- Original Message ----- From: "John McNally" <[EMAIL PROTECTED]> To: "Turbine Developers List" <[EMAIL PROTECTED]> Sent: Friday, March 15, 2002 10:54 PM Subject: Re: cvs commit: jakarta-turbine-torque/src/java/org/apache/torque/adapter DBMM.java > Is there a specific implementation that is known to be thread-unsafe? I > looked at sun's implementation some time ago and concluded that > format(date) could be called by multiple threads safely. Maybe I was > wrong, but why would someone implement the format method to modify > object properties? > > john mcnally > > [EMAIL PROTECTED] wrote: > > > > dlr 02/03/15 13:29:37 > > > > Modified: src/java/org/apache/torque/adapter DBMM.java > > Log: > > SimpleDateFormat is not thread-safe -- corrected usage problem turned > > up by conversation with Bill Schneider <[EMAIL PROTECTED]>. > > > > Revision Changes Path > > 1.7 +3 -4 jakarta-turbine-torque/src/java/org/apache/torque/adapter/DBMM.java > > > > Index: DBMM.java > > =================================================================== > > RCS file: /home/cvs/jakarta-turbine-torque/src/java/org/apache/torque/adapter/DBMM.jav a,v > > retrieving revision 1.6 > > retrieving revision 1.7 > > diff -u -u -r1.6 -r1.7 > > --- DBMM.java 22 Aug 2001 20:12:08 -0000 1.6 > > +++ DBMM.java 15 Mar 2002 21:29:37 -0000 1.7 > > @@ -73,13 +73,12 @@ > > * > > * @author <a href="mailto:[EMAIL PROTECTED]";>Jon S. Stevens</a> > > * @author <a href="mailto:[EMAIL PROTECTED]";>Brett McLaughlin</a> > > - * @version $Id: DBMM.java,v 1.6 2001/08/22 20:12:08 dlr Exp $ > > + * @version $Id: DBMM.java,v 1.7 2002/03/15 21:29:37 dlr Exp $ > > */ > > public class DBMM > > extends DB > > { > > - private static final SimpleDateFormat DATE_FORMATTER = > > - new SimpleDateFormat("yyyyMMddHHmmss"); > > + private static final String DATE_FORMAT = "yyyyMMddHHmmss"; > > > > /** > > * Empty constructor. > > @@ -216,6 +215,6 @@ > > */ > > public String getDateString(Date date) > > { > > - return '\'' + DATE_FORMATTER.format(date) + '\''; > > + return '\'' + new SimpleDateFormat(DATE_FORMAT).format(date) + '\''; > > } > > } > > > > > > > > > > -- > > To unsubscribe, e-mail: <mailto:[EMAIL PROTECTED]> > > For additional commands, e-mail: <mailto:[EMAIL PROTECTED]> > > -- > To unsubscribe, e-mail: <mailto:[EMAIL PROTECTED]> > For additional commands, e-mail: <mailto:[EMAIL PROTECTED]> > -- To unsubscribe, e-mail: <mailto:[EMAIL PROTECTED]> For additional commands, e-mail: <mailto:[EMAIL PROTECTED]>
