> -----Original Message----- > From: Daniel Rall [mailto:[EMAIL PROTECTED]] > Sent: Friday, March 15, 2002 2:34 PM > To: Turbine Developers List > Subject: Re: cvs commit: > jakarta-turbine-torque/src/java/org/apache/torqu e/adapter DBMM.java > > > Fedor Karpelevitch <[EMAIL PROTECTED]> writes: > > > I just looked at it and it is not threadsafe at all - it > stores a lot of > > state in instance vars. So calls should either be > synchronized or you should > > create a new instance each time (or keep one instance per > thread, but it > > would be PITA to maintain...) > > Using a ThreadLocal variable would handle that fairly easily (though > to those unfamiliar with the ThreadLocal class, it makes the code > harder to read, as you say), but I'm unsure whether it would be a net > performance gain or not (we should really run a test to be sure). > What do you think, Fedor? > > - Dan
I guess I agree that it is easier to implement formatting manually and drop SDF altogather. We do not need any flexibility here and string concat should be perfectly fine and in fact should perform better. fedor. -- To unsubscribe, e-mail: <mailto:[EMAIL PROTECTED]> For additional commands, e-mail: <mailto:[EMAIL PROTECTED]>
