Ben Peter and Rodney Schneider on turbine-user are asking for redirect code to be removed from turbine before 2.2 release. Rodney has asked before.
On Thursday, March 28, 2002, at 11:21 AM, Daniel Rall wrote: > If you think something needs to be done to the source, please send an > enumeration of the steps and the reasoning behind them to the > [EMAIL PROTECTED] list. Dan, Peter Lynch provided patches and rationale back in October: <http://www.mail-archive.com/turbine- dev%40jakarta.apache.org/msg03660.html> I looked over the patches this morning. There's distracting whitespace changes in the patches, but they don't look too bad to me. I didn't try to apply them 'cos I didn't see a resolution to the discussion back in October. I think Peter made his point fairly well, and I would support the removal of the redirect code. But I don't know how the deprecation rules fit in this case. If deprecation policy calls for preserving the existing redirect functionality, then I offer the following refactoring ideas: 1. extract methods on the areas where Peter's patches would have removed redirect code. 2. deprecate the newly extracted methods 3. add a configuration option to enable/disable the redirection and make the extracted methods pay attention to the config option If deprecation policy does not apply here, then manually apply Peter's changes to the 2.2 code and be done with it. -Eric -- To unsubscribe, e-mail: <mailto:[EMAIL PROTECTED]> For additional commands, e-mail: <mailto:[EMAIL PROTECTED]>
