Bartek/John,

In my code I made a version of FileItem.write that uses a FileOutputStream
instead of
a writer.  This allows the user to upload a binary (e.g. GIF) file as well
as text.
May I propose that you modify DefaultFileItem to do this as well?

                FileOutputStream fout = null;
            try
            {
                                fout = new FileOutputStream(file);
                                fout.write(FileItemObject.get());
            }
            finally
            {
                                if (fout != null)
                                        fout.close();
            }

Best, Will Glass-Husain

> John McNally wrote:
> >
> > > Please test patches before sending them in.  This will not compile.
It
> > also assumes text uploads and loads the entire file into memory.  The
> > write method exists in order to not do these things.

> Sorry for my inattention. I promise the next patch(es) will be of higher
> quality.

> > But thanks for the idea, I have added related code to the version of
> > DefaultFileItem I am working on.
> >
> > john mcnally

> Bartek Walter


--
To unsubscribe, e-mail:   <mailto:[EMAIL PROTECTED]>
For additional commands, e-mail: <mailto:[EMAIL PROTECTED]>

Reply via email to