I posted a patch for the DTD the other day changing Date to DateString
and removing DateKey to match the Fulcrum FieldFactory code. However,
I'm assuming the Turbine 2.x uses Date instead of DateString and Date
also makes more sense than DateString as it's more consistent with the
others...e.g. boolean/BooleanField, int/IntegerField. 

Date/DateField would be ideal, so if the DateStringField class could
also be renamed to just DateField, I think it makes more sense.

But besides that, here's a patch for FieldFactory to return the
DateStringField for type="Date" instead of type="DateString".

The current patch ignores "DateString" just as the existing version
ignores "Date", however, I think this is appropriate as "DateString" is
not in the intake.dtd.

- Stephen
Index: src/java/org/apache/fulcrum/intake/model/FieldFactory.java
===================================================================
RCS file: 
/home/cvspublic/jakarta-turbine-fulcrum/src/java/org/apache/fulcrum/intake/model/FieldFactory.java,v
retrieving revision 1.1.1.1
diff -u -r1.1.1.1 FieldFactory.java
--- src/java/org/apache/fulcrum/intake/model/FieldFactory.java  30 May 2002 02:27:18 
-0000      1.1.1.1
+++ src/java/org/apache/fulcrum/intake/model/FieldFactory.java  25 Jun 2002 20:26:04 
+-0000
@@ -145,7 +145,7 @@
                 }
             }
                        );
-        fieldCtors.put("DateString", new FieldFactory.FieldCtor()
+        fieldCtors.put("Date", new FieldFactory.FieldCtor()
             {
                 public Field getInstance(XmlField f, Group g)
                     throws Exception

--
To unsubscribe, e-mail:   <mailto:[EMAIL PROTECTED]>
For additional commands, e-mail: <mailto:[EMAIL PROTECTED]>

Reply via email to