Hello,

I read a TODO comment about 

    private String decodeRequest(Context context, String filename,
                                 OutputStream output, String charset,
                                 String encoding)
        throws ServiceException
    {
        // TODO: Push this method of getting character set & encoding
        // from RunData back into Turbine.
        // charset  = ((RunData) data).getCharSet();
        // encoding = ((RunData) data).getTemplateEncoding();


But at this moment, I think we need some patch for handle charset/encoding stuff 
correctly.

Thanks.

youngho
Index: TurbineVelocityService.java
===================================================================
RCS file: 
/home/cvspublic/jakarta-turbine-fulcrum/src/java/org/apache/fulcrum/velocity/TurbineVelocityService.java,v
retrieving revision 1.1.1.1
diff -r1.1.1.1 TurbineVelocityService.java
120a121,135
>      * Default character set to use if not specified by caller.
>      */
>     private static final String DEFAULT_TEMPLATE_ENCODING = "ISO8859_1";
> 
>       /**
>        * Default character set fot velocity
>        */
>       private static String charSet;
> 
>       /**
>        * Encoding of velocity Template files
>        */
>       private static String templateEncoding;
> 
>     /**
136c151
<      * Whether or not to use the eventCartridge. Defaults to true. 
---
>      * Whether or not to use the eventCartridge. Defaults to true.
367d381
< 
370c384
<             charset = DEFAULT_CHAR_SET;
---
>             charset = charSet;
372a387,391
>         if( encoding == null )
>         {
>                       encoding = templateEncoding;
>               }
> 
579a599,603
> 
>                       charSet = getConfiguration().getString("output.encoding" , 
>DEFAULT_CHAR_SET);
> 
>                       templateEncoding = 
>getConfiguration().getString("input.encoding" , DEFAULT_TEMPLATE_ENCODING);
> 

--
To unsubscribe, e-mail:   <mailto:[EMAIL PROTECTED]>
For additional commands, e-mail: <mailto:[EMAIL PROTECTED]>

Reply via email to