On Mon, Jan 06, 2003 at 02:33:23PM -0800, Daniel Rall wrote:
> >   +    /**
> >   +     * This method is gone in Torque HEAD, but still in Torque 3.0, so is still
> >   +     * here. It will be removed once Fulcrum moves to the next Torque 3.x.
> >   +     *
> >   +     * @deprecated
> >   +     */
> >        public String getDefaultMap()
> >        {
> >   -        return Torque.getDefaultMap();
> >   +        return Torque.getDefaultDB();
> >        }
> >   +
> >    }
> 
> Your log message doesn't say anything about the commit to 
> TurbineDatabaseService.java, which even with a message would look a tad 
> suspicious.

Sorry about that; the change was in response to Martin requesting
that I make sure Fulcrum didn't use any of Torque 3.0's deprecated
methods as the methods are now gone in Torque HEAD.

So while I checked off that change in my mind by highlighting the
update to Torque 3.0 in the log message (I did run through the diff
to make sure I was only committing what I intended), but you're
right in that it means nothing to anyone besides myself and perhaps
Martin.

(And to clarify the suspicion, Torque.getDefaultMap() is just the
old name for Torque.getDefaultDB(). I just compiled with the
deprecated flag and removed the offending call to
Torque.getDefaultDB(). Though now that I look again, the removal
needs to be percolated up to the DatabaseService interface and
TurbineDB.)

Should I completely remove getDefaultMap in Fulcrum or mark it as
deprecated and keep the current method in the above diff that just
calls Torque.getDefaultDB?

- Stephen

--
To unsubscribe, e-mail:   <mailto:[EMAIL PROTECTED]>
For additional commands, e-mail: <mailto:[EMAIL PROTECTED]>

Reply via email to