I will restore it. I just thought that it should be consistent. There were only 3 of the 10 or so attributes that were set through the bean accessor functions. I will just make them all go through bean accessors.
> -----Original Message----- > From: Henning P. Schmiedehausen [mailto:[EMAIL PROTECTED]] > Sent: Thursday, January 16, 2003 5:02 AM > To: [EMAIL PROTECTED] > Subject: Re: cvs commit: > jakarta-turbine-2/src/java/org/apache/turbine/services/intake/ > xmlmodel XmlField.java > > > [EMAIL PROTECTED] writes: > > > - setName(attrib.getValue("name")); > > + name = attrib.getValue("name"); > > Nah. I do -1 this change. Please restore the old state! > > Please keep the Bean accessors. Going back to direct field > access hurts everyone who tries to derive from these objects. > > Please, Quinton, don't get overearger in your changes. I want > this discussed first! > > Regards > Henning > -- > Dipl.-Inf. (Univ.) Henning P. Schmiedehausen -- > Geschaeftsfuehrer > INTERMETA - Gesellschaft fuer Mehrwertdienste mbH [EMAIL PROTECTED] > > Am Schwabachgrund 22 Fon.: 09131 / 50654-0 [EMAIL PROTECTED] > D-91054 Buckenhof Fax.: 09131 / 50654-20 > > -- > To unsubscribe, e-mail: > <mailto:turbine-dev-> [EMAIL PROTECTED]> > For > additional commands, > e-mail: <mailto:[EMAIL PROTECTED]> > > -- To unsubscribe, e-mail: <mailto:[EMAIL PROTECTED]> For additional commands, e-mail: <mailto:[EMAIL PROTECTED]>
