+1 for 2.3 > -----Original Message----- > From: [EMAIL PROTECTED] [mailto:[EMAIL PROTECTED] > Sent: Tuesday, February 25, 2003 5:39 PM > To: [EMAIL PROTECTED] > Subject: RE: VelocityEmail Change Proposal > > > Hi all, > > I hadn't heard back from anyone on this, whether people think > this would be good or not. > > After thinking more about this, I would like to change > TR.props so that if you have a setting mail.session=jndi then > it would pull the javax.mail.Session using the key mail.jndi.key. > > mail.session=jndi > mail.jndi.key=env/cmp/mail/myjdbcmailsession > > and if you didn't have the mail.session, then it would look > for the old: mail.host. > > What do people think? I would like to pass in > javax.mail.session to the HTMLEmail class, but that requires > someone to commit the patch that I posted below. Otherwise I > think I can get the mail.host from the javax.mail.Session via > Session.getProperty("mail.host"). > > I just want to know if I should plow forward with this in the > 2.3 tree or keep it private. > > Eric Pugh > > -----Original Message----- > From: [EMAIL PROTECTED] [mailto:[EMAIL PROTECTED] > Sent: Thursday, February 20, 2003 10:36 AM > To: [EMAIL PROTECTED] > Subject: VelocityEmail Change Proposal > > > Hi all, > > At this point Turbine is pretty focussed on getting it's > configuration from a TR.props. For instance, what mail host > to use is dependent on what is set as smtp.host. > > I am finding this requires lots of funky build scripts, > because my smtp.host is different in development from > production. And, regular admin types can't easily edit > tr.props files. > > Therefore we are switching to using JNDI for as many of our > settings that change as possible. I would like to change the > VelocityEmail to take in a jndi javax.mail.session to use > instead. This would require a change to the tr.props as well > to specify mail.session=jndi/props or something of that nature? > > What do you all think? Towards this end, I submitted a patch > to commons-email ( > http://nagoya.apache.org/bugzilla/show_bug.cgi?id=16859) a > couple weeks ago to allow it to take a javax.mail.Session as > well as a mailHost. However that patch hasn't been dealt with. > > If this sounds like a good enhancement, then if someone who > is also a committer on commons could apply my patch, I'll > make the changes to tr.props to make the mail host a > properties or jndi setting. > > sincerely, > Eric Pugh >
--------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
