> -----Original Message-----
> From: Henning P. Schmiedehausen [mailto:[EMAIL PROTECTED] 
> Sent: Friday, March 14, 2003 5:56 AM
> To: [EMAIL PROTECTED]
> Subject: Re: cvs commit: 
> jakarta-turbine-2/src/java/org/apache/turbine Turbine.java
> 
> 
> [EMAIL PROTECTED] writes:
> 
> >  -    public static void setTurbineServletConfig(ServletConfig s)
> >  +    public static void 
> setTurbineServletConfig(ServletConfig config)
> >       {
> >  -        servletConfig = s;
> >  +        servletConfig = config;
> 
> Can we use  "this.servletConfig = servletConfig"?

No.  This is a static method.
 
> >  -        servletContext = s;
> >  +        servletContext = context;
> 
> same.
> 
> >  -        String[] names = data.getSession().getValueNames();
> >  -        if (names != null)
> >  +        for( Enumeration enum = 
> data.getSession().getAttributeNames();
> >  +                enum.hasMoreElements(); )
> 
> I'm not sure but this might have been a bug workaround for 
> some buggy servlet containers, which return null for
> getValueNames()/getAttributeNames() if none are set. You 
> might want to check. Not sure about this, though.
>       Regards
>               Henning
> 
> -- 
> Dipl.-Inf. (Univ.) Henning P. Schmiedehausen          INTERMETA GmbH
> [EMAIL PROTECTED]        +49 9131 50 654 0   http://www.intermeta.de/
> 
> Java, perl, Solaris, Linux, xSP Consulting, Web Services 
> freelance consultant -- Jakarta Turbine Development  -- hero for hire
> 
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: [EMAIL PROTECTED]
> For additional commands, e-mail: [EMAIL PROTECTED]
> 
> 
> 

---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Reply via email to