henning 2003/07/15 03:13:57
Modified: src/java/org/apache/turbine/services/intake/model
StringField.java
Log:
While this is a simple checkin, it fixes a not quite so simple bug
(IMHO). The problem was dragged in in the 1.3 revision changes made
by quinton. There as a test added that said "if the supplied string is
empty or null value", then set this field to "null".
This is fine, as long as all of the fields in your form are
"required". Now I have an application that has a few "required" fields
and quite some "non-required" fields. So they're submitted empty by the
user. As they're empty and valid (they're not required), its value (the
empty string) ends up in doSetValue. Here the test tells the StringField
to put "null" into its internal value.
This null value is propagated via setProperties(Object obj) to an
underlying bean. I use a torque generated object here, which in turn
inserts it value into a database table. Where the column is defined as
required="true", which should 'just work'. Because the user sent the
empty String ("") to the application.
However, the null value in the bean is translated to SQL NULL. Which
in turn gets refused by the database (required == NOT NULL). So the
user gets an errors which is not clear at all.
IMHO this behaviour of Intake is a bug. An empty string should be an
empty string in Intake, too. We can discuss about the behaviour when
"null" is passed to doSetValue() in the StringField, which would
restore the behaviour before the 1.3 revision (and similar with
Fulcrum, which uses quite different code).
Discussion wanted.
Revision Changes Path
1.9 +3 -3
jakarta-turbine-2/src/java/org/apache/turbine/services/intake/model/StringField.java
Index: StringField.java
===================================================================
RCS file:
/home/cvs/jakarta-turbine-2/src/java/org/apache/turbine/services/intake/model/StringField.java,v
retrieving revision 1.8
retrieving revision 1.9
diff -u -r1.8 -r1.9
--- StringField.java 19 Jun 2003 14:56:30 -0000 1.8
+++ StringField.java 15 Jul 2003 10:13:57 -0000 1.9
@@ -116,14 +116,14 @@
String[] sval = new String[ss.length];
for (int i = 0; i < ss.length; i++)
{
- sval[i] = (StringUtils.isNotEmpty(ss[i])) ? ss[i] : null;
+ sval[i] = (StringUtils.isNotEmpty(ss[i])) ? ss[i] : "";
}
setTestValue(sval);
}
else
{
String val = parser.getString(getKey());
- setTestValue(StringUtils.isNotEmpty(val) ? val : null);
+ setTestValue(StringUtils.isNotEmpty(val) ? val : "");
}
}
---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
