I have applied the fix.. However, there is one more problem.. The method on BaseUnitTest.release() doesn't do anything. The only way to shut down a compoent is to call dispose on the container, which ends up being a call to tearDown..
I added a unit test to TestComponentTest to demonstrate the problem.. Often in testing we want to shut down a component to see what happens... On the plus side, the Disoposable method is now called, so I was able to remove the hack in my BaseQuartzTestCase! Eric > -----Original Message----- > From: Siegfried Goeschl [mailto:[EMAIL PROTECTED] > Sent: Wednesday, November 03, 2004 11:05 AM > To: Turbine Developers List; Eric Pugh > Subject: [fulcrum-yaafi] Patches for fulcrum-yaafi 1.0.3-dev > > > Hi folks, > > I fixed the following bugs in fulcrum-yaafi 1.0.3-dev > > 1) implementation not backward compatible to JDK 1.3.x > (ServiceComponentImpl.java) > > cvs diff > src\java\org\apache\fulcrum\yaafi\framework\container\ServiceCompo > nentImpl.java > (in directory W:\work\jakarta\jakarta-turbine-fulcrum\yaafi\) > Index: > src/java/org/apache/fulcrum/yaafi/framework/container/ServiceCompo > nentImpl.java > =================================================================== > RCS file: > /home/cvspublic/jakarta-turbine-fulcrum/yaafi/src/java/org/apache/ > fulcrum/yaafi/framework/container/ServiceComponentImpl.java,v > retrieving revision 1.1 > diff -r1.1 ServiceComponentImpl.java > 148c148 > < throw new RuntimeException(msg,t); > --- > > throw new RuntimeException(msg); > 206c206 > < throw new RuntimeException(msg,t); > --- > > throw new RuntimeException(msg); > 346c346 > < throw new RuntimeException(msg,t); > --- > > throw new RuntimeException(msg); > > 2) the components were not properly disposed (ServiceContainerImpl.java) > > cvs diff > src\java\org\apache\fulcrum\yaafi\framework\container\ServiceConta > inerImpl.java > (in directory W:\work\jakarta\jakarta-turbine-fulcrum\yaafi\) > Index: > src/java/org/apache/fulcrum/yaafi/framework/container/ServiceConta > inerImpl.java > =================================================================== > RCS file: > /home/cvspublic/jakarta-turbine-fulcrum/yaafi/src/java/org/apache/ > fulcrum/yaafi/framework/container/ServiceContainerImpl.java,v > retrieving revision 1.1 > diff -r1.1 ServiceContainerImpl.java > 536c536 > < > --- > > this.decommision( serviceComponent ); > > > --------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
