[EMAIL PROTECTED] writes:
> Log:
> Add a facade helper class
Personally, I consider the addition of the static facades to the
Turbine services (yes, I am very guilty of my share) one of the bigger
mistakes of Turbine.
Is it so hard to get a Service reference from the container?
> +
> + /**
> + * Avalon component lifecycle method
> + */
> + public void service( ServiceManager manager) {
> +
> + MimeTypeServiceFacade.setMimeTypeService(this);
> +
> + }
Uh; while this looks IoC style, it connects the implementation to the
facade which is IIRC a violation of the facade pattern (where it
should be the other way around). And users are in for really nasty
surprises if their Service implementation forgets to to this setting.
(And while I'm already at it: a "setService()" setter would match the
getService() getter... :-) )
Regards
Henning
--
Dipl.-Inf. (Univ.) Henning P. Schmiedehausen INTERMETA GmbH
[EMAIL PROTECTED] +49 9131 50 654 0 http://www.intermeta.de/
RedHat Certified Engineer -- Jakarta Turbine Development -- hero for hire
Linux, Java, perl, Solaris -- Consulting, Training, Development
What is more important to you...
[ ] Product Security
or [ ] Quality of Sales and Marketing Support
-- actual question from a Microsoft customer survey
---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
