Henning P. Schmiedehausen wrote: >Scott Eade <[EMAIL PROTECTED]> writes: > > >>+ throw (Exception) ite.getTargetException(); >> >> >[...] > > >>+ throw (Exception) ite.getTargetException(); >> >> > >And I firmly -1 it in that incarnation. Please read my comments to the >commit message of r221603. > > Doh!
>If you simply cast a potential Throwable to Exception, then you are in >for CCE's sooner or later and _that_ will leave users bewildered even >more. If there really is a need for fixing this, let's fix it >correctly. > > Agreed, but of course if you are getting something other than an Exception you have bigger problems :-) I didn't see any point in wrapping the Throwable in a TurbineException - the ITE is probably a truer indication of what has gone on. I am happy to wrap this if you feel strongly about it. Cheers, Scott --------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
