Glenn A. McAllister wrote:

>On Mon, 27 May 2002, St�phane MOR wrote:
>
>>Hi,
>>
>>Checkstyle reports contains inactive links to files containing no 
>>errors, and shows an
>>error count of "0".
>>
>
>Why is that a problem?  
>
>Glenn McAllister
>SOMA Networks, Inc.
>
The Checkstyle report contains only the files that have a problem in them.
In one of my projects, I managed to have this report contain no link at 
all, no
error reported (which was quite long !!).

Let's say you have a file "ErrorCode.java" that contains 1 error.
Checkstyle reports the file with an error count of "1" at "ErrorCode.java",
and a subsection describing the error.
Now, you fix it, and run maven:site. The Checkstyle report still contains
the link to the "ErrorCode.java" subsection, but shows an error count of 
"0",
and no "ErrorCode.java" subsection.
Last, run maven:site once more, without editing any file.
Now, the Checkstyle report doesn't mention the file or the error at all.

If the goal of the Checkstyle report is to report only errors (which it
does after 2 runs ), then I think that it is best to *only* have errors 
reported.

The patch I sent saves 1 run.

Though, we could also have Checkstyle report the files with no errors, 
to show
the compliance with a coding standard as a quality factor. It could be 
another
element, along with test reports and metrics, promoting the quality of 
the code...

Thanks,
St�phane

PS: if you callback JRefactory before Checkstyle, the "0" error lines 
will never
disappear, even after 2 runs, as they are considered new files in each run.


_________________________________________________________
Do You Yahoo!?
Get your free @yahoo.com address at http://mail.yahoo.com


--
To unsubscribe, e-mail:   <mailto:[EMAIL PROTECTED]>
For additional commands, e-mail: <mailto:[EMAIL PROTECTED]>

Reply via email to