dion        2002/07/14 09:15:20

  Modified:    src/java/org/apache/maven/jelly/tags
                        ServerStartedCheckTag.java
  Log:
  Style violations
  
  Revision  Changes    Path
  1.2       +13 -15    
jakarta-turbine-maven/src/java/org/apache/maven/jelly/tags/ServerStartedCheckTag.java
  
  Index: ServerStartedCheckTag.java
  ===================================================================
  RCS file: 
/home/cvs/jakarta-turbine-maven/src/java/org/apache/maven/jelly/tags/ServerStartedCheckTag.java,v
  retrieving revision 1.1
  retrieving revision 1.2
  diff -u -r1.1 -r1.2
  --- ServerStartedCheckTag.java        7 Jul 2002 23:50:36 -0000       1.1
  +++ ServerStartedCheckTag.java        14 Jul 2002 16:15:20 -0000      1.2
  @@ -66,9 +66,6 @@
   import org.apache.commons.jelly.TagSupport;
   import org.apache.commons.jelly.XMLOutput;
   
  -import org.apache.maven.MavenUtils;
  -import org.apache.maven.project.Project;
  -
   import org.apache.commons.logging.Log;
   import org.apache.commons.logging.LogFactory;
   
  @@ -96,17 +93,17 @@
       /**
        * the URL to check if the
        */
  -    private String URL  = null;
  +    private String url  = null;
   
       /**
        * the status value that http errors begin at
        */
  -    private int errorsBeginAt=400;
  +    private int errorsBeginAt = 400;
   
       /**
        * Required property name to set to true if the url can be reached
        *
  -     * @param the property to set to true if the URL can be reached
  +     * @param propertyName the property to set to true if the URL can be reached
        */
       public void setPropertyName(String propertyName)
       {
  @@ -116,11 +113,11 @@
       /**
        * Required URL to check to see if the server is running.
        *
  -     * @param The URL to check to see if a server is running
  +     * @param url The URL to check to see if a server is running
        */
  -    public void setURL(String URL)
  +    public void setURL(String url)
       {
  -        this.URL = URL;
  +        this.url = url;
       }
   
       /**
  @@ -137,7 +134,7 @@
           // till I find a better way
           Log log = LogFactory.getLog(context.getClass());
   
  -        if (this.URL == null)
  +        if (this.url == null)
           {
             throw new MissingAttributeException("URL");
           }
  @@ -146,12 +143,12 @@
             throw new MissingAttributeException("propertyName");
           }
   
  -        log.info("Checking for " + this.URL);
  +        log.info("Checking for " + this.url);
   
           try
           {
               // this code pretty much copied from Ant 1.5's Http condition
  -            URL url = new URL(this.URL);
  +            URL url = new URL(this.url);
               try
               {
                   URLConnection conn = url.openConnection();
  @@ -160,7 +157,7 @@
                       HttpURLConnection http = (HttpURLConnection) conn;
                       int code = http.getResponseCode();
   
  -                    log.info("Result code for " + this.URL + " was " + code);
  +                    log.info("Result code for " + this.url + " was " + code);
   
                       if (code > 0 && code < this.errorsBeginAt)
                       {
  @@ -170,13 +167,14 @@
               }
               catch (java.io.IOException ioe)
               {
  -                //log("The URL connection could not be established to " + this.URL, 
Project.MSG_VERBOSE);
  +                //log("The URL connection could not be established to " + 
  +                //    this.URL, Project.MSG_VERBOSE);
               }
           }
           catch (MalformedURLException mue)
           {
               log.error("The URL you provided as a property to this "
  -            + "tag was malformed: " + this.URL);
  +            + "tag was malformed: " + this.url);
               throw new MalformedURLException();
           }
           finally
  
  
  

--
To unsubscribe, e-mail:   <mailto:[EMAIL PROTECTED]>
For additional commands, e-mail: <mailto:[EMAIL PROTECTED]>

Reply via email to