Thanks Tom. Sorry to take so long to apply your patch. It is now fixed in CVS. The Cactus plugin now only supports J2EE 1.3 because ATM I don't know how to support both J2EE 1.2 and 1.3 as a maven project dependencies are static. I can see 3 solutions: - refactor cactus to provide only one jar both for J2EE 1.2 and 1.3 (might not be too easy to do, not sure though) - provide 2 maven plugins, one for 1.2 and one for 1.3 - do not bother as everyone is using Servlet 2.3. But we'll face the same issue soon as Servlet 2.4 are currently being developed with Tomcat 5...
Any idea? Thanks -Vincent > -----Original Message----- > From: Tom Palmer [mailto:tomp@;uk.uu.net] > Sent: 23 October 2002 14:48 > To: 'Turbine Maven Developers List' > Subject: RE: [Patch] Fix cactus so that maven.cactus.webxml can be > overridden > > Hi Vincent, > > That was my original thought (i.e. surround the <j:set > var="maven.cactus.webxml"/> with a <j:if/> statement) but I figured that > you > wanted to the tomcat startup/shutdown to default to using > ${plugin.dir}/conf/web-13.xml. Thinking about it I realise that the > definition of maven.cactus.webxml to maven.cactus.tomcat4x.webxml should > be > surrounded by a <j:if/> statement otherwise it will not allow > maven.cactus.webxml to be overridden if you are using tomcat to run the > cactus tests. > > However I don't think that we can just define maven.cactus.webxml if it > isn't already defined (at least, not in tomcat4x.jelly) as this will not > allow the use of other servers that support a different spec (e.g. a J2EE > 1.2 container) - hence the reason for defining > maven.cactus.tomcat4x.webxml. The setting of maven.cactus.webxml before > running the cactus:tomcat-4x-run goal should ensure that > maven.cactus.webxml > is set to the tomcat default if no custom web.xml file is defined > (something > that my patch does not do due to the missing <j:if/> statement). > > My use of the cactus plugin to generate an EAR containing the cactus WAR > and an EJB Jar so that I can test my EJB's within the container. As I > deploy > this to JBoss I do not use any of the startup/shutdown parts of the > plugin. > > (I must remember to think through the other use-cases next time... :) ) > > Regards, > > Tom > > > -----Original Message----- > > From: Vincent Massol [mailto:vmassol@;octo.com] > > Sent: 23 October 2002 14:44 > > To: 'Turbine Maven Developers List' > > Subject: RE: [Patch] Fix cactus so that maven.cactus.webxml can be > > overridden > > > > > > Hi Tom, > > > > Thanks for the patch. Don't you think it would be cleaner if we simply > > make a check as to whether the maven.cactus.webxml property is defined > > as in: > > > > If maven.cactus.webxml not define then > > Define maven.cactus.webxml > > > > Actually, I'm not sure I understand how the patch works or how you use > > the plugin. I understand that you define maven.cactus.webxml in your > > project.properties, is that correct? It seems to me that the > > patch will > > not use that property any more for packaging the war... Am I > > wrong here? > > > > Thanks > > -Vincent > > > > > > > -----Original Message----- > > > From: Tom Palmer [mailto:tomp@;uk.uu.net] > > > Sent: 23 October 2002 14:21 > > > To: '[EMAIL PROTECTED]' > > > Subject: [Patch] Fix cactus so that maven.cactus.webxml can be > > overridden > > > > > > Hi, > > > > > > The attached patch alters the cactus plugin so that the property > > > maven.cactus.webxml can be overridden allowing the user to supply a > > custom > > > web.xml file for the cactus WAR (especially important if > > you are using > > the > > > cactus plugin to test EJB's). > > > > > > This will restore the behaviour of revision 1.2 of > > > src/plugin-builds/cactus/scripts/tomcat.4x.jelly. Note that > > the patch > > > SHOULD > > > work but I haven't tested that it keeps the desired behaviour of > > revision > > > 1.3 (it does fix my case above). > > > > > > Regards, > > > > > > Tom > > > > > > > > -- > > To unsubscribe, e-mail: > <mailto:turbine-maven-dev-unsubscribe@;jakarta.apache.org> > For additional commands, e-mail: > <mailto:turbine-maven-dev-help@;jakarta.apache.org> > > -- > To unsubscribe, e-mail: <mailto:turbine-maven-dev- > [EMAIL PROTECTED]> > For additional commands, e-mail: <mailto:turbine-maven-dev- > [EMAIL PROTECTED]> -- To unsubscribe, e-mail: <mailto:turbine-maven-dev-unsubscribe@;jakarta.apache.org> For additional commands, e-mail: <mailto:turbine-maven-dev-help@;jakarta.apache.org>
