I'm +1 on having a property available. -- dIon Gillard, Multitask Consulting Blog: http://www.freeroller.net/page/dion/Weblog Work: http://www.multitask.com.au
[EMAIL PROTECTED] wrote on 26/11/2002 03:42:57 AM: > After digging into ChangeLog, I have more of a philsophy question... In a > previous patch, I had changed the plugin.jelly to check to see if connection > information was provided. In my current interation, I changed > ChangeLog.java.. > > For something like this though, where should the check be made? A couple > plugins require repository information to work, so should the check be in > some sort of shared java code? Or should a plugin, if called, assume that > all data will be provided, and throw errors if something like the repository > is missing. In that case, it seems that maybe all plugins should share > something like maven.mode.online, maybe maven.repository.availble that would > be true/false depending on the repository being set or not. > > Looking for a little guidence before I start changing code! > > Eric Pugh > > -----Original Message----- > From: [EMAIL PROTECTED] [mailto:[EMAIL PROTECTED]] > Sent: Sunday, November 24, 2002 9:44 PM > To: Turbine Maven Developers List > Subject: RE: [PATCH] Maven Site fails on ChangeLog Part II > > > Last time I tried the patch, it didn't work.....does this one work? > -- > dIon Gillard, Multitask Consulting > Blog: http://www.freeroller.net/page/dion/Weblog > Work: http://www.multitask.com.au > > > [EMAIL PROTECTED] wrote on 23/11/2002 01:52:26 AM: > > > Hi all, > > > > I had sent this patch in a while ago to be able to run the site target > when > > you don't have a SCM specified. I did a fresh get to fix the SAX parser > > issue, and noticed this patch had never been applied. Can someone apply > it, > > or specify what I need to change to get it applied...? If you don't > have a > > SCM, then you shouldn't be forced to run in offline mode! > > > > Eric Pugh > > > > -----Original Message----- > > From: Pugh, Eric > > Sent: Friday, November 01, 2002 1:40 PM > > To: 'Turbine Maven Developers List' > > Subject: [PATCH] Maven Site fails on ChangeLog Part II > > > > > > Hi, > > > > I looked at the changelog code, and ended up adding a clause in the > jelly > > script to not call the changelog plugin if the scm information hasn't > been > > provided. Attached is the patch. However, what I couldn't get to work > (new > > to jelly and all) is the customized error message. I keep getting the > "The > > Changelog is available in the online mode only." message, not the one > > mentioning the missing POM element. > > > > Hopefully someone can take this and at least apply the check part of the > > patch. > > > > Eric Pugh > > > > -----Original Message----- > > From: [EMAIL PROTECTED] [mailto:[EMAIL PROTECTED]] > > Sent: Wednesday, October 30, 2002 8:57 PM > > To: Turbine Maven Developers List > > Subject: Re: Maven Site fails on ChangeLog Part II > > > > > > I'm +1 > > -- > > dIon Gillard, Multitask Consulting > > Work: http://www.multitask.com.au > > Developers: http://adslgateway.multitask.com.au/developers > > > > > > [EMAIL PROTECTED] wrote on 30/10/2002 05:06:21 AM: > > > > > Hi, > > > > > > I did figure out that maven.mode.online=false would prevent it from > > running > > > changelog, however, I feel that this isn't the best solution since I > am > > > actually online, I just don't have a support SCM. I looked at the > > > ChangeLog.java and it seems that in the doExecute method, if > > "connection" > > > is null or blank, then just emit a warning that there is no changelog > > > available or something.. If this sounds like a good plan, I can make > > the > > > change... > > > > > > Eric Pugh > > > > > > -----Original Message----- > > > From: Pugh, Eric > > > Sent: Tuesday, October 29, 2002 12:56 PM > > > To: 'Turbine Maven Developers List' > > > Subject: Maven Site fails on ChangeLog > > > > > > > > > Hi, > > > > > > I used to be able to run the maven site target, and changelog would > just > > > skip over (because my SCM is Visual SourceSafe). Now however it > fails: > > > In file > > C:\java\dbforms\examples\selftest\target\checkstyle-raw-report.xml > > > time: > > > 1035914158000 > > > Out file > > > > C:\java\dbforms\examples\selftest\target\generated-xdocs\checkstyle-rep > > > ort.xml time: 1035914122000 > > > Style file > > c:\java\maven\plugins\maven-checkstyle-plugin-1.1\checkstyle.dvsl > > > tim > > > e: 1035912714000 > > > Processing > > > C:\java\dbforms\examples\selftest\target\checkstyle-raw-report.xml to > > > > > > > > > C:\java\dbforms\examples\selftest\target\generated-xdocs\checkstyle-report.x > > > ml > > > Processed > > C:\java\dbforms\examples\selftest\target\checkstyle-raw-report.xml > > > in > > > 94 ms. > > > > > > > > > checkstyle: > > > > > > changelog:generate: > > > > > > [ERROR] BUILD FAILED > > > [ERROR] repository connection string not specified > > > Total time: 6 seconds > > > > > > C:\java\dbforms\examples\selftest> > > > > > > If I comment out this part of the POM: > > > <repository> > > > <connection></connection> > > > <url></url> > > > </repository> > > > > > > it still fails.. > > > > > > Eric Pugh > > > > > ForwardSourceID:NT000881F6 > > > > -- > > To unsubscribe, e-mail: > > <mailto:[EMAIL PROTECTED]> > > For additional commands, e-mail: > > <mailto:[EMAIL PROTECTED]> > > > ForwardSourceID:NT00091B52 > > -- > To unsubscribe, e-mail: > <mailto:[EMAIL PROTECTED]> > For additional commands, e-mail: > <mailto:[EMAIL PROTECTED]> > ForwardSourceID:NT000921B2 -- To unsubscribe, e-mail: <mailto:[EMAIL PROTECTED]> For additional commands, e-mail: <mailto:[EMAIL PROTECTED]>
