This works ok for me.
I'll apply it.
--
dIon Gillard, Multitask Consulting
Blog: http://www.freeroller.net/page/dion/Weblog
Work: http://www.multitask.com.au
Michal Maczka <[EMAIL PROTECTED]> wrote on 11/01/2003 02:19:08 AM:
> Sorry for taking your time, but I don't understand your comments
>
> I used ${lib.getUrlPath()} which is a method of Artifact.
> I did not use anything like ${lib.groupId}.
>
> Basically instead of working with list of dependencies(like it was
before) I
> worked with list of artifacts.
> I bet that this is correct approach as there is one to one mapping
> (unidirectional) between artifact and dependency.
> Is there anything agaist it?
>
>
> In Dependency (I got last snapshot of Maven) we have:
>
>
> /**
> * Get the group id.
> *
> * @return The group id for the dependency.
> */
> public String getGroupId()
> {
> return groupId != null ? groupId : getProjectId();
> }
>
>
> so getGroupId() itself (which is indirectly used in Artifact class) is
> responsible for setting correctly what you have called
"artifactDirectory".
> BTH: I see no property named artifactDirectory neither in Dependency nor
in
> Artifact
> Are you speaking about some local changes which are not in CVS?
>
>
> Michal
>
> > -----Original Message-----
> > From: Jason van Zyl [mailto:[EMAIL PROTECTED]]
> > Sent: Friday, January 10, 2003 3:52 PM
> > To: Turbine Maven Developers List
> > Subject: Re: [eclipse plugin] Patch - gruupId fix
> >
> >
> > On Fri, 2003-01-10 at 09:25, Michal Maczka wrote:
> > > This patch fixes the problem of generation of classpath
> > entry for eclipse
> > > project when groupId is used.
> > >
> > > It seems that there is more bugs of this type plaguing
> > other plugins as
> > > well.
> > > The same type of patch is needed for example by ear plugin.
> > > I can apply the patch soon...
> >
> > You want to use ${lib.artifactDirectory} and not ${lib.groupId} as the
> > groupId may not be set. The logic has been changed such that if the
> > artifactDirectory will be the groupId if it is set otherwise
> > it will be
> > project id. Checkout the deploy plugin for usage.
> >
> > If you send me patches using ${lib.artifactDirectory} I'll apply them.
> >
> > > Michal
> > >
> > > Index: plugin.jelly
> > > ===================================================================
> > > RCS file:
> > >
> > /home/cvspublic/jakarta-turbine-maven/src/plugins-build/eclips
> > e/plugin.jelly
> > > ,v
> > > retrieving revision 1.15
> > > diff -u -r1.15 plugin.jelly
> > > --- plugin.jelly 4 Jan 2003 05:37:02 -0000 1.15
> > > +++ plugin.jelly 10 Jan 2003 14:20:44 -0000
> > > @@ -47,8 +47,8 @@
> > > </j:if>
> > >
> > > <classpathentry kind="var" path="JRE_LIB"
> > rootpath="JRE_SRCROOT"
> > > sourcepath="JRE_SRC"/>
> > > - <j:forEach var="lib" items="${pom.dependencies}">
> > > - <classpathentry kind="var"
> > > path="MAVEN_REPO/${lib.getProjectId()}/jars/${lib.getArtifact()}"/>
> > > + <j:forEach var="lib" items="${pom.artifacts}">
> > > + <classpathentry kind="var"
> > path="MAVEN_REPO${lib.getUrlPath()}"/>
> > > </j:forEach>
> > > <classpathentry kind="output"
> > path="target\eclipse\classes"/>
> > > </classpath>
> > >
> > > --
> > > To unsubscribe, e-mail:
> > <mailto:[EMAIL PROTECTED]>
> > > For additional commands, e-mail:
> > <mailto:[EMAIL PROTECTED]>
> > --
> > jvz.
> >
> > Jason van Zyl
> > [EMAIL PROTECTED]
> > http://tambora.zenplex.org
> >
> > In short, man creates for himself a new religion of a rational
> > and technical order to justify his work and to be justified in it.
> >
> > -- Jacques Ellul, The Technological Society
> >
> >
> > --
> > To unsubscribe, e-mail:
> > <mailto:[EMAIL PROTECTED]>
> > For additional commands, e-mail:
> > <mailto:[EMAIL PROTECTED]>
> >
>
> --
> To unsubscribe, e-mail: <mailto:turbine-maven-dev-
> [EMAIL PROTECTED]>
> For additional commands, e-mail: <mailto:turbine-maven-dev-
> [EMAIL PROTECTED]>
>
> ForwardSourceID:NT000A1B62
--
To unsubscribe, e-mail: <mailto:[EMAIL PROTECTED]>
For additional commands, e-mail: <mailto:[EMAIL PROTECTED]>
