Hi Eric,
Eric Dobbs wrote:
> I looked into this problem about a year ago (I think). I made a lot
> of noise on the list about Criteria needing to be completely
> replaced. But I never followed through with code. Thanks for taking
> it on.
>
> I think these are the main areas where you'll need to look. And
> unfortunately, there's no test code.
I've found some simple test code for the Criteria object in the src/test
directory from the code I checked out of cvs. I can run the tests but I
get this error:
[junit] log4j:ERROR No appenders could be found for category
(org.apache.torque.Torque).
[junit] log4j:ERROR Please initialize the log4j system properly.
I guess I won't start modifying these tests unless I can get log4j
running with them, and of course there's also the possibility that you
might be able to write some more tests here
>
> org.apache.torque.util.BasePeer
> org.apache.torque.util.SqlExpression
> org.apache.torque.util.Criteria
> org.apache.torque.adaptor.DB*
From a preliminary observation it seems like I might be able to just
modify the Criterion object internals, but leave all of the interface
methods intact. I am going to try and attempt this.
> Some time in the next week or so I have a test I will be adding
> because I need to fix some behavior with Dates. Afterwards I may be
> able to facilitate with some tests.
>
> I find BasePeer can be confusing. In some places it is using Village
> (http://share.whichever.com/village) to generate prepared statements,
> and in other places it generates the SQL on its own.
>
> Good luck. And thanks again.
Thanks for your help. I'll be in touch shortly.
CHEERS> SAM
--
To unsubscribe, e-mail: <mailto:[EMAIL PROTECTED]>
For additional commands, e-mail: <mailto:[EMAIL PROTECTED]>