Sam, Please resend your patch as an /attached/ file. The one you've sent seems to be corrupted. -Eric
On Wednesday, April 24, 2002, at 09:27 PM, Sam Joseph wrote: > Following some comments from James Taylor (thanks James), I rewote the > Criteria code patch to include as much documentation as possible and > also reduce line length to under 80 characters where possible. > > I hope that this will help with acceptance of this patch which supports > two things. > > 1. It makes the PeersHowTo documentation correct by allowing proper > arbitrary depth nesting of "or" and "and" clauses > 2. It adds a parseCriterionString and parseCriterion methods to > Criteria that allows a String representation of a Criterion object to > be transformed back into a Criterion Object. > > Point 1 is supported without making any changes to Criteria, and at the > same time maintaining all existing Criterion methods in their current > form. > I hope very much you will consider using this patch, as I think a > number of people have been caught out by the failure of Criterion to > handle arbitrary depth nested "and" and "or" statements. If point 2 is > not considered necessary or just bad code, then please let me know and > I can submit a patch that supports just point 1 above, which is the > most important after all. > > Apologies for my multiple submissions of this patch, but this is the > first time I have submitted a patch to an open source project and I am > only gradually working out how to do this. [snip] -- To unsubscribe, e-mail: <mailto:[EMAIL PROTECTED]> For additional commands, e-mail: <mailto:[EMAIL PROTECTED]>
