Eric Dobbs wrote: > I've committed my own test which demonstrates the > precedence problem, and committed the patch that fixes > it. > > Thanks for submitting the patch.
No problem. Feels good to contribute. Oops, I should have added my name to the list of authors on the patch - don't suppose there's any chance of that happening now: + * @author <a href="mailto:[EMAIL PROTECTED]";>Sam Joseph</a> > In the test you sent > I didn't see the test that confirms the conversion. I > assume you removed that 'cos I removed the parsing > method. I'd like to take a look at that test anyway to > see if I can find a way to work that in too. Yeah, I guess I didn't have an explicit test of that.(bad programmer, bad), partly because it is difficult to assert How about this: x_crit2.and(x_crit3).or(x_crit4.and(x_crit5)); String x_correct = "((myTable2.myColumn2='myValue2' AND myTable3.myColumn3='myValue3') OR (myTable4.myColumn4='myValue4' AND myTable5.myColumn5='myValue5'))"; assertTrue(x_correct.equals(x_crit2.toString())); x_crit6.and(x_crit7).or(x_crit8).and(x_crit9); x_correct = "(((myTable2.myColumn2='myValue2' AND myTable3.myColumn3='myValue3') OR myTable4.myColumn4='myValue4') AND myTable5.myColumn5='myValue5')"; assertTrue(x_correct.equals(x_crit6.toString())); CHEERS> SAM -- To unsubscribe, e-mail: <mailto:[EMAIL PROTECTED]> For additional commands, e-mail: <mailto:[EMAIL PROTECTED]>
